Skip to content

Mypy stubs #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 23, 2018
Merged

Mypy stubs #1641

merged 6 commits into from
Oct 23, 2018

Conversation

replomancer
Copy link
Member

@replomancer replomancer commented Oct 19, 2018

This is for #1456 and takes care of mypy complaints about external libraries.

MyPy requires stub files for external libraries. Only one stub file is added here. It's for numpy. The others (msgpack, pandas and setuptools stubs) are currently not easy to find, but may become easily available at some point.

A mypy.ini config file has been added. These options can't go to pyproject.toml, because MyPy doesn't support it.

Because of missing stub files and import complaints, ignore_missing_imports is set to True in mypy.ini.

@iamtrask
Copy link
Member

Well done! Thank you sir!

@iamtrask iamtrask merged commit 42c00a3 into OpenMined:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants