Skip to content

Fix broken quick-adjust slider #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WeirdRubberDuck
Copy link
Collaborator

@ylvaselling
Copy link
Collaborator

ylvaselling commented Jun 25, 2025

Still some issues; i assume this is still the quick adjust? Or maybe it is not a part of this pr
https://github.com/user-attachments/assets/4f5298cc-70ec-47db-b647-e19c5bc70e09

@WeirdRubberDuck
Copy link
Collaborator Author

Still some issues; i assume this is still the quick adjust? Or maybe it is not a part of this pr https://github.com/user-attachments/assets/4f5298cc-70ec-47db-b647-e19c5bc70e09

Interesting, and good catch. Seems like if it is clicked to fast there are still issues, indeed..

@WeirdRubberDuck
Copy link
Collaborator Author

Still some issues; i assume this is still the quick adjust? Or maybe it is not a part of this pr https://github.com/user-attachments/assets/4f5298cc-70ec-47db-b647-e19c5bc70e09

Interesting, and good catch. Seems like if it is clicked to fast there are still issues, indeed..

This is a bit of a diffiuclt issue to solve, though, since it's an issue with how we're setting the time rather than how the component works. It happens if we manage to trigger a new change in the quick-adjust before the time has started interpolating to the previous value

I made a change that makes it less likely to trigger this issue, but that also leads to it not being possible to set the quick-adjust by just clicking on the slider - one must drag. Le time know what you think about this @ylvaselling, I'm not sure what a good solution is

@WeirdRubberDuck WeirdRubberDuck requested review from ylvaselling and engbergandreas and removed request for ylvaselling July 2, 2025 07:29
@alexanderbock
Copy link
Member

alexanderbock commented Jul 14, 2025

The user-polling was unanimous in having it snap back to the previous deltatime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick adjust slider does not reset delta time
3 participants