Skip to content

Show all keybinds mapped to a key in keyboard view #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 21, 2025

Conversation

WeirdRubberDuck
Copy link
Collaborator

closes OpenSpace/OpenSpace#3679

Also fixes some styling-related issues when multiple mapped keys were shown.

Here's what it looks like now. New/updated parts highlighted in pink

  1. Scrollbar on keyboard instead of entire window
  2. Show how many actions mapped to a certain key
  3. Scrollbar on just the bottom part, where the list of mapped actions are (note that I could not get it to work for just the actions list, so the title scrolls too...)
  4. Show keybind for each action card (necessary now that we show e.g. the SHIFT+X key on selecting X)

image

@alexanderbock
Copy link
Member

How hard would it be to have the keyboard view shrink proportionally instead of having a scrollbar?

@WeirdRubberDuck
Copy link
Collaborator Author

How hard would it be to have the keyboard view shrink proportionally instead of having a scrollbar?

I didn't look into it in great detail, but it seemed "hard" to me since we are currently setting all the sizes to exact pixels in the CSS file. My impression was that it would be time-consuming and hard to update the CSS to get it to work in a way that looks good when resizing, and the scrollbox seemed like a very easy compromise that at least works better than it did before

@alexanderbock
Copy link
Member

We'll leave it then 👍

@WeirdRubberDuck WeirdRubberDuck merged commit a22ca52 into master Jul 21, 2025
@WeirdRubberDuck WeirdRubberDuck deleted the issue/3679-keybind-show-all-variants branch July 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard viewer should show all variants of key bindings
2 participants