Create archive tar with appropriate flags rather than chown #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Testing here. Tested with all other Linux types in a previous run. If Windows fails the S3 upload, it's almost definitely for a different reason. |
In order to prevent file ownership issues when extracting the tarball, we were chowning all files to root before creating the tarball. Using chown on Windows in Cygywin in GitHub Actions is dicey, so instead, we use the appropriate tar flags to ensure all files have ownership by 0:0. When extracted, if extracting as a non-root user, since a non-root user can't create files they don't have access to, that user will end up owning the files.
nmburgan
force-pushed
the
remove_chown_archive
branch
from
1101764 to
65c01a7
Compare
bastelfreak
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent file ownership issues when extracting the tarball, we were chowning all files to root before creating the tarball. Using chown on Windows in Cygywin in GitHub Actions is dicey, so instead, we use the appropriate tar flags to ensure all files have ownership by 0:0. When extracted, if extracting as a non-root user, since a non-root user can't create files they don't have access to, that user will end up owning the files.