-
Notifications
You must be signed in to change notification settings - Fork 169
Stellar: Stablecoin #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Stellar: Stablecoin #575
Conversation
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces stablecoin support by adding a new Stablecoin tab, refactors access control to support both Ownable and Roles, and updates the default versions along with a macro-based implementation for fungible and non‐fungible token contracts.
- Adds a new Stablecoin module with allow-/blocklist limitations
- Updates access control logic across contracts to include roles support
- Refactors the contract function definition to leverage the default_impl macro
Reviewed Changes
Copilot reviewed 20 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/ui/src/stellar/AccessControlSection.svelte | Implements UI for access control with reactive updates |
packages/core/stellar/src/utils/version.ts | Updates version constants to 0.3.0-rc.2 |
packages/core/stellar/src/utils/define-functions.ts | Refactors function definitions to remove implicit name handling |
packages/core/stellar/src/stablecoin.ts | Adds new stablecoin logic and limitations handling |
packages/core/stellar/src/set-access-control.ts | Expands access options to include roles and adjusts access enforcement logic |
Others (tests, API, generators, etc.) | Updates to support stablecoin inclusion and access control consistency |
Comments suppressed due to low confidence (1)
packages/core/stellar/src/stablecoin.ts:57
- [nitpick] Using 'type' as a variable name can be confusing due to its overlap with the TypeScript keyword; consider renaming it to 'isAllowlist' or a similar descriptive name to improve code clarity.
const type = mode === 'allowlist';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great in general, big chunk of work, thanks 💯
After the comments have resolved, should be good to go. Will test the webapp in the meantime and will let you know if I find any bug 👍
Co-authored-by: Eric Lau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great work!
default_impl
macroTodo: