Skip to content
This repository was archived by the owner on Jun 10, 2019. It is now read-only.

(issue #516) clean up commented codes and todo usages #521

Merged
merged 1 commit into from
Oct 1, 2017
Merged

(issue #516) clean up commented codes and todo usages #521

merged 1 commit into from
Oct 1, 2017

Conversation

pyitphyoaung
Copy link
Contributor

Description of changes

This PR cleans commented codes and TODO usages.

Cleaned TODO notes and related sources for backlog update (if any)


SOURCE: config/webpack.config.dev.js AND config/webpack.config.prod.js

// TODO: Disable require.ensure as it's not a standard language feature.
// We are waiting for facebook/create-react-app#2176.
// { parser: { requireEnsure: false } },

SOURCE: src/scenes/home/families/jumboQuote/jumboQuote.js

// TODO: Ditch bluebird promise for axios to drop a dependency
// TODO: Is there a need to move the quotes to a back-end API endpoint, or should we just bail on the promise-based API request idea for this data?

SOURCE: src/scenes/home/history/timelineEvent/timelineEvent.js

// TODO: Force eventTitle to Title case with Regex

SOURCE: src/shared/utils/cookieHelper.js

// TODO we could validate the signature as well (issue#281)

Issue Resolved

Fixes #516

@kylemh
Copy link
Member

kylemh commented Oct 1, 2017

Sweet! I've added issues for the TODOs that were undocumented.

@kylemh kylemh merged commit a2184c1 into OperationCode:master Oct 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent commented out code and TODOs from being submitted in a PR
2 participants