This repository was archived by the owner on Jun 10, 2019. It is now read-only.
(issue #516) clean up commented codes and todo usages #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR cleans commented codes and TODO usages.
Cleaned TODO notes and related sources for backlog update (if any)
SOURCE: config/webpack.config.dev.js AND config/webpack.config.prod.js
// TODO: Disable require.ensure as it's not a standard language feature.
// We are waiting for facebook/create-react-app#2176.
// { parser: { requireEnsure: false } },
SOURCE: src/scenes/home/families/jumboQuote/jumboQuote.js
// TODO: Ditch bluebird promise for axios to drop a dependency
// TODO: Is there a need to move the quotes to a back-end API endpoint, or should we just bail on the promise-based API request idea for this data?
SOURCE: src/scenes/home/history/timelineEvent/timelineEvent.js
// TODO: Force eventTitle to Title case with Regex
SOURCE: src/shared/utils/cookieHelper.js
// TODO we could validate the signature as well (issue#281)
Issue Resolved
Fixes #516