This repository was archived by the owner on Jun 10, 2019. It is now read-only.
add if statement to check if Raven object has been instantiated#958
Closed
ZacharyKearns wants to merge 1 commit into
Closed
add if statement to check if Raven object has been instantiated#958ZacharyKearns wants to merge 1 commit into
ZacharyKearns wants to merge 1 commit into
Conversation
jjhampton
reviewed
May 5, 2018
| return window.location.host === 'operationcode.org'; | ||
| } | ||
| }).install(); | ||
| if (window.Raven) { |
Member
There was a problem hiding this comment.
@ZacharyKearns Wrapping the inline <script> tag in an if-statement prevents the Raven-related console errors, but that's because the if-statement will never be true. So this also prevents the Raven.config method from ever being called. That's because when this script tag runs, Raven hasn't been loaded because it's loaded asynchronously w/ a defer attribute on line 37 in the head (this was introduced as a performance improvement in PR #932).
Removing the defer would probably fix this (and there would be no need for the if-statement either, since Raven would have already been loaded synchronously from CDN).
@kylemh I see three options here:
- Remove the
deferfrom the Raven CDN script for now (simple fix) - Explore one of the more complicated ways to load Raven asynchronously (Asynchronous Loading and Capturing Errors getsentry/sentry-javascript#169 outlines some of these)
- Remove Raven completely - I've never used it, and I don't know of any of the current maintainers who have, either. YAGNI
Thoughts?
jjhampton
suggested changes
May 5, 2018
Member
|
Fixed in #980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Checks to make sure that the Raven object exists before calling any methods on it.
Issue Resolved
Fixes #955