Chore merge main from 6ca9152 to 8c10ee8#2676
Merged
julien-deramond merged 6 commits intomainfrom Aug 5, 2024
Merged
Conversation
julien-deramond
force-pushed
the
main-jd-chore-merge-from-6ca9152
branch
from
8929dde to
4548c35
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
twbs/bootstrap@c05cd9a: no masthead notice in Boostedaria-hidden="true"to decorative SVGs twbs/bootstrap#40691 for some use cases that have been forgottenNote
Please note that I haven't reintroduced twbs/bootstrap@ac831aa#diff-17bd0a43dcea923cbb44c877ce1462c41b5624ccafa66f29cb6d0946707f096c because we have a lot of
focusable="false"in Boosted. We need to check with the a11y team if we can get rid of them since they're not probably useful anymore.I've created a dedicated issue for that: #2677