Skip to content

Fix audit a11y: Change wrong images labels#2709

Merged
julien-deramond merged 7 commits intomainfrom
main-his-wrong-img-labels
Sep 11, 2024
Merged

Fix audit a11y: Change wrong images labels#2709
julien-deramond merged 7 commits intomainfrom
main-his-wrong-img-labels

Conversation

@hannahiss
Copy link
Copy Markdown
Member

@hannahiss hannahiss commented Aug 23, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#2667

Description

Change labels:

  • for Orange logos
  • for tooltip example with an SVG

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 23, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit cd500d1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66e0513a5964b900087ea707
😎 Deploy Preview https://deploy-preview-2709--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hannahiss hannahiss added 👂 accessibility v5 📖 documentation Improvements or additions to documentation labels Aug 27, 2024
@hannahiss hannahiss marked this pull request as ready for review August 27, 2024 08:13
@hannahiss hannahiss changed the title Change wrong images labels Fix audit a11y: Change wrong images labels Aug 27, 2024
@hannahiss hannahiss mentioned this pull request Aug 27, 2024
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is still running for me, but the logo is mainly used in the header and often used as a part of the brand name. For instance I'm thinking about Orange Cyberdefense, Orange Foundation, etc... Which title would then say Orange master logo Cyberdefense. My opinion is balancing between:

  • We are a documentation so everything isn't perfect but we ease our UX.
  • If people want to use the logo, they need to adapt the label and so we can have whatever in here.

Comment thread site/content/docs/5.3/about/brand.md Outdated
@hannahiss
Copy link
Copy Markdown
Member Author

The question is still running for me, but the logo is mainly used in the header and often used as a part of the brand name. For instance I'm thinking about Orange Cyberdefense, Orange Foundation, etc... Which title would then say Orange master logo Cyberdefense. My opinion is balancing between:

  • We are a documentation so everything isn't perfect but we ease our UX.
  • If people want to use the logo, they need to adapt the label and so we can have whatever in here.

We didn't talk about this: of course, in the context of a website, if the logo is in a links that leads to home page, as it often does, the label shouldn't be "XXX logo" but something like "XXX home". For this, I think that developers can be inspired by Boosted code itself, don't you think? In this example, we don't have any context, so it would be weird to use such a label...

Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread site/content/docs/5.3/components/tooltips.md Outdated
@julien-deramond julien-deramond self-requested a review September 11, 2024 12:52
@julien-deramond julien-deramond merged commit 424a255 into main Sep 11, 2024
@julien-deramond julien-deramond deleted the main-his-wrong-img-labels branch September 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👂 accessibility 📖 documentation Improvements or additions to documentation v5

Projects

Development

Successfully merging this pull request may close these issues.

3 participants