Skip to content

bug: wrong accessible name for control item with decorative icon 392#430

Merged
nouha06 merged 7 commits intodevelopfrom
392-buga11y-checkbox-item-icon-wrong-accessible-name
Oct 28, 2025
Merged

bug: wrong accessible name for control item with decorative icon 392#430
nouha06 merged 7 commits intodevelopfrom
392-buga11y-checkbox-item-icon-wrong-accessible-name

Conversation

@nouha06
Copy link
Copy Markdown
Member

@nouha06 nouha06 commented Oct 17, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#392

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@nouha06 nouha06 requested a review from Tayebsed93 October 17, 2025 16:13
@nouha06 nouha06 self-assigned this Oct 17, 2025
@nouha06 nouha06 added 🐞 bug Something isn't working 👂 accessibility labels Oct 17, 2025
@nouha06 nouha06 linked an issue Oct 17, 2025 that may be closed by this pull request
[Bug][A11Y] Checkbox item + icon : wrong accessible name #392
Closed
1 task
@nouha06 nouha06 added 🧰 library ⭐ v1.0 Tickets needed for mobile v1.0 release labels Oct 17, 2025
@nouha06
Merge branch 'develop' into 392-buga11y-checkbox-item-icon-wrong-acce…
4f295a4 
…ssible-name

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@nouha06
fix: remove the two swipes to reach the component for accessibility f…
9d62916 
…eature (checkbox item)
@nouha06
Merge branch 'develop' into 392-buga11y-checkbox-item-icon-wrong-acce…
43d1a82 
…ssible-name

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@nouha06 nouha06 added 💥 blocking TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it and removed 💥 blocking labels Oct 27, 2025
@Tayebsed93
Copy link
Copy Markdown
Contributor

Tayebsed93 commented Oct 28, 2025 •
edited
Loading

prendre en compte les remarques de @pya35

@Tayebsed93 Tayebsed93 removed ⌛ waiting for validations TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it labels Oct 28, 2025
@nouha06
Merge branch 'develop' into 392-buga11y-checkbox-item-icon-wrong-acce…
42ba47f 
…ssible-name

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
@nouha06
Merge branch 'develop' into 392-buga11y-checkbox-item-icon-wrong-acce…
a4d9d83 
…ssible-name

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
#	ouds_core/lib/components/checkbox/ouds_checkbox_item.dart
@nouha06
fix: test non regression
2c81e5f
@nouha06 nouha06 added the TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it label Oct 28, 2025
@nouha06 nouha06 merged commit bc2d4b3 into develop Oct 28, 2025
3 checks passed
@nouha06 nouha06 deleted the 392-buga11y-checkbox-item-icon-wrong-accessible-name branch October 28, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Tayebsed93 Tayebsed93 Tayebsed93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nouha06 nouha06

Labels

👂 accessibility 🐞 bug Something isn't working 🧰 library ⭐ v1.0 Tickets needed for mobile v1.0 release TestFlight blocking iOS issue: TestFlight unavailable. We’ve created this label while we fix it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug][A11Y] Checkbox item + icon : wrong accessible name

2 participants

@nouha06 @Tayebsed93