Fields in Orchard display as "&" instead of "&"

[LegendORC]

I just download Orchard 1.10.
and create new Field on Blog as Start Date & Time.
When i try to create new Blog it's display Start Date & Time correctly on the UI.
But... when i click on the "Save" button without put any data.
Error message will display as Start Date & Time is required. instead of Start Date & Time is required.

Thank you.

[sebastienros]

Because AddModelError will re-encode the error message, we need to prevent T from encoding the name by wrapping it in an IHtmlString
https://github.com/OrchardCMS/Orchard/blob/dev/src/Orchard.Web/Modules/Orchard.Fields/Drivers/DateTimeFieldDriver.cs#L158

[rtpHarry]

@sebastienros I have looked into this issue. I searched the solution with this regex to see if others were affected by it:

updater\.AddModelError\(.*DisplayName.*\);

Some of them used a slightly different pattern:

updater.AddModelError(GetPrefix(field, part), T("{0} is required.", T(field.DisplayName)));

See the param is wrapped in a T() as well. This fixes the issue:

Is this the solution or a workaround?

[sebastienros]

Whatever, I know we already use T for some things like this, but the use of T might be misleading as the actual solution to translate is to use a different module, and also a different localizer.