Skip to content

User name format in CreateUserActivity#6951

Merged
sebastienros merged 1 commit intoOrchardCMS:1.10.xfrom
xkproject:#6946_UserNameFormat
Aug 4, 2016
Merged

User name format in CreateUserActivity#6951
sebastienros merged 1 commit intoOrchardCMS:1.10.xfrom
xkproject:#6946_UserNameFormat

Conversation

@psp589
Copy link
Copy Markdown
Contributor

@psp589 psp589 commented Jun 3, 2016

if the user creates a user name with whitespaces at the end or the start this will cause you a lot of problems with physical paths and the virtual ones,because in physicals you can't have whitespaces but in the orchard objects you'll have the paths with the whitespaces (using the user name with the whitespaces to compose the path)

@dnfclas
Copy link
Copy Markdown

dnfclas commented Jun 3, 2016

Hi @psp589, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@psp589 psp589 changed the title remove whitespaces User name format in CreateUserActivity Jun 3, 2016
@dnfclas
Copy link
Copy Markdown

dnfclas commented Jul 2, 2016

@psp589, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@sebastienros sebastienros merged commit 0deab6b into OrchardCMS:1.10.x Aug 4, 2016
@sebastienros
Copy link
Copy Markdown
Member

Can you please create an issue for this PR so we can track the fix when we release?

@psp589
Copy link
Copy Markdown
Contributor Author

psp589 commented Aug 5, 2016

The issue was already created #6946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants