Consider "returnUrl" in the OpenId actions#7558
Merged
sebastienros merged 3 commits intoOrchardCMS:devfrom Mar 2, 2017
Merged
Conversation
… the `AzureActiveDirectory` settings class
sebastienros
reviewed
Feb 9, 2017
|
|
||
| if (Request.IsAuthenticated) { | ||
| Redirect(Url.Content("~/")); | ||
| Redirect(returnUrl); |
Member
There was a problem hiding this comment.
Don't use returnUrl anywhere in a redirect without checking the destination is allowed, like RedirectLocal does or if it needs to go to a provider's domain, then check it too.
This comment applies to every change in this PR.
Contributor
Author
There was a problem hiding this comment.
The code is updated to use the RedierctLocal extension method instead, as we never redirect to providers from the AccountController
sebastienros
reviewed
Mar 2, 2017
| @Html.TextBoxFor(m => m.GraphApiUrl, new { @class = "text large" }) | ||
| <span class="hint">@T("Typically https://graph.windows.net")</span> | ||
|
|
||
| @Html.LabelFor(m => m.GraphApiKey, T("Graph API Key")) |
Member
There was a problem hiding this comment.
I will merge the PR, but can you create a new one that removes the usage of LabelFor and instead use a <label> tag? Otherwise there can be issues with double-encoding (try to use an accent for instance, or < in the text)
sebastienros
reviewed
Mar 2, 2017
| } | ||
|
|
||
| public string GraphApiKey | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider
returnUrlin the OpenId actions. Fixes issue #7530