Skip to content

Fixing references / view file due to view compilation errors#7719

Merged
sebastienros merged 2 commits intoOrchardCMS:devfrom
jimasp:viewcompilation
Jun 15, 2017
Merged

Fixing references / view file due to view compilation errors#7719
sebastienros merged 2 commits intoOrchardCMS:devfrom
jimasp:viewcompilation

Conversation

@jimasp
Copy link
Copy Markdown
Contributor

@jimasp jimasp commented May 28, 2017

see: #7713

@dnfclas
Copy link
Copy Markdown

dnfclas commented May 28, 2017

@jimasp,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@jimasp jimasp changed the title View compilation - fixing bad refs and adding aspnet_compiler task View compilation May 28, 2017
@jimasp jimasp changed the title View compilation Fixing some references May 29, 2017
@jimasp jimasp changed the title Fixing some references Fixing references / view file due to view compilation errors May 29, 2017
</configSections>
<system.web.webPages.razor>
<host factoryType="System.Web.Mvc.MvcWebRazorHostFactory, System.Web.Mvc, Version=5.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35" />
<host factoryType="System.Web.Mvc.MvcWebRazorHostFactory, System.Web.Mvc, Version=5.2.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the specflow web.config file also needs to change

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienros I think that was also discovered when there was a problem with running the site with IIS Expess, but I don't remember now where we got with that.

@Html.TextBoxFor(m => m.Name, new { @class = "text medium" })
<span class="hint">@T("The name of this template, which can be used to reference from code (as when using shape type names) and tokens.")</span>
</div>
</fieldset>
Copy link
Copy Markdown
Member

@BenedekFarkas BenedekFarkas Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think removing this is correct, although I also see build errors with view compilation from this piece of code - I'll look into it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually this needs to be removed as Template has TitlePart!

@sebastienros
Copy link
Copy Markdown
Member

Should we merge this one or wait for more changes from you @BenedekFarkas ?

@BenedekFarkas
Copy link
Copy Markdown
Member

I think we can merge this, as it definitely brings us closer to the goal, but let's not close the issue yet.
I'll open another PR with my changes after this one is merged, then we can discuss how to proceed (judging from what @jimasp commented on the issue, he's testing from VS, but I think validating with MSBuild is also necessary, see my comments on the issue about that).

@sebastienros sebastienros merged commit 09cea0f into OrchardCMS:dev Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants