[#7729] Text tokens enhancements#7730
Merged
sebastienros merged 4 commits intoOrchardCMS:1.10.xfrom Jun 22, 2017
Merged
Conversation
Contributor
HermesSbicego-Laser
commented
Jun 16, 2017
HermesSbicego-Laser
commented
- Adds the "TrimStart:" text token
- Adds the ability to chain text to "Limit:", "TrimEnd:", "Format:" and "TrimStart:" tokens
- Adds the "TrimStart:" text token - Adds the ability to chain text to "Limit:", "TrimEnd:", "Format:" and "TrimStart:" tokens
- Adds the "TrimStart:" text token - Adds the ability to chain text to "Limit:", "TrimEnd:", "Format:" and "TrimStart:" tokens
…ture/7729_TextTokenEnhancement
…29_TextTokenEnhancement # Conflicts: # src/Orchard.Web/Modules/Orchard.Tokens/Providers/TextTokens.cs
Member
|
No tests were altered, just new ones, sounds good. And looking at this code I am happy we have chosen to use a template library in OC instead. |
Contributor
Author
|
Yes, chaining tokens with paramters are not so easy to write, neither intuitive. Wich template library has been adopted in OC? Could be adopted in O1 too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.