Removes IDisplayedContentItemHandler in favour of ICacheTagProvider (#7792)#7793
Merged
sebastienros merged 2 commits intoOrchardCMS:devfrom Aug 3, 2017
Merged
Conversation
paynecrl97
commented
Jul 27, 2017
| cacheItemTags.AddRange(cacheTagProvider.GetTags()); | ||
| } | ||
| catch (Exception ex) { | ||
| Logger.Warning(ex, "Cache tags from provider {0} will not be added to the cached item ({1}) because the provider threw an exception when asked to provide tags.", cacheTagProvider.GetType().FullName, _cacheKey); |
Member
Author
There was a problem hiding this comment.
An individual provider failing should not prevent the request from succeeding. Log warn and continue.
paynecrl97
commented
Jul 27, 2017
| private readonly ITagCache _tagCache; | ||
| private readonly IDisplayedContentItemHandler _displayedContentItemHandler; | ||
| private readonly IWorkContextAccessor _workContextAccessor; | ||
| private readonly IThemeManager _themeManager; |
Member
Author
There was a problem hiding this comment.
ITagCache and IThemeManager were already unused before this change, I just removed them to help tidy up.
Member
|
Talked to Chris at length about this and reviewed these changes with him. GTG as far as I'm concerned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7792 for more info.