Fix #6825 by reducing the changed files to those only related to the issue#7916
Fix #6825 by reducing the changed files to those only related to the issue#7916sebastienros merged 3 commits intoOrchardCMS:1.10.xfrom HengzheLi:#6825
Conversation
|
|
|
@li0803 no problem, thank you for submitting the PR |
| @@ -1,15 +1,26 @@ | |||
| for /f "usebackq tokens=*" %%i in (`lib\vswhere\vswhere -latest -version "[15.0,16.0)" -requires Microsoft.Component.MSBuild -property installationPath`) do ( | |||
There was a problem hiding this comment.
Changes in this file are really needed? It looks that are not really related with thi topic of the PR
There was a problem hiding this comment.
Well, the topic of the PR in reality is very open
There was a problem hiding this comment.
I made this branch from master. And this change is a head commit to 1.10.x by sebastienros on master branch.
And master is a stable branch. So I think I'd better submit this PR to another one.
| <Compile Include="Models\NavigationQueryPartRecord.cs" /> | ||
| <Compile Include="Models\QueryPart.cs" /> | ||
| <Compile Include="Providers\Builders\MemberBindingsStep.cs" /> | ||
| <Compile Include="Providers\Excutors\MemberBindingsStep.cs" /> |
There was a problem hiding this comment.
Typo Excutors should be Executors
| using Orchard.Recipes.Services; | ||
|
|
||
| namespace Orchard.Projections.Providers.Builders | ||
| { |
There was a problem hiding this comment.
Better use curly braces on the same line following style used in Orchard for consistency for all the files in this PR
|
Thanks, please apply the changes requested by @jersiovic |
|
apply jersiovic 2) and 3) review suggestion |
4 participants
#6825 fixed #3275 by @jersiovic, but it was prevented from merging as it changed too many files.
This PR, I branch it from master, only apply the commit 106ff07 and bd531cf from jersiovic in #6825 of which were key commits for fixing #3275 and there are any other changes.
PS: hope this PR does not offense your contributions @jersiovic as it reuse your works. If it does, I will close it.