[8008]Workflow404cssfiles#8009
Closed
HengzheLi wants to merge 9 commits intoOrchardCMS:devfrom
HengzheLi:workflow404cssfiles
Closed
[8008]Workflow404cssfiles#8009HengzheLi wants to merge 9 commits intoOrchardCMS:devfrom HengzheLi:workflow404cssfiles
HengzheLi wants to merge 9 commits intoOrchardCMS:devfrom
HengzheLi:workflow404cssfiles
Conversation
add Id property to BooleanFilterForm shape for consisting with other built-in filter form
merge official code
add ".css" sufix to style resource's url. set BasePath for every activity's "WorkflowsActivity-*.css" resource
|
|
||
| foreach (var activityName in activityNames) { | ||
| manifest.DefineStyle(activityName).SetUrl(activityName.HtmlClassify()).SetDependencies("WorkflowsAdmin"); | ||
| var activities = _activitiesManager.Value.GetActivities().ToArray();//.Select(x => "WorkflowsActivity-" + x.Name).ToArray(); |
| var assemblyName = activity.GetType().Assembly.GetName().Name; | ||
| var styleName = "WorkflowsActivity-" + activity.Name; | ||
| manifest.DefineStyle(styleName) | ||
| .SetBasePath(VirtualPathUtility.AppendTrailingSlash("~/Modules/"+assemblyName+"/styles/")) |
Member
There was a problem hiding this comment.
Indentation and spaces around +
| var styleName = "WorkflowsActivity-" + activity.Name; | ||
| manifest.DefineStyle(styleName) | ||
| .SetBasePath(VirtualPathUtility.AppendTrailingSlash("~/Modules/"+assemblyName+"/styles/")) | ||
| .SetUrl(styleName.HtmlClassify()+".css") |
check if the file exists as #7873 suggest
Contributor
|
Please decline this PR since the source repository doesn't exist anymore. The changes are re-implemented in the Lombiq fork and a PR was created. #8201 |
BenedekFarkas
pushed a commit
that referenced
this pull request
May 15, 2019
Improves the changes from #8009 by HengzheLi, but allows loading Activity stylesheets from any extension (including custom paths), not just modules
Member
|
@HengzheLi @sebastienros I'll close this as #8201 solves the issues this PR was submitted for, but also improves the original implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8008