Skip to content

Live preview feature (Orchard.ContentPreview back-port; Lombiq Technologies: WESD-1)#8260

Merged
sebastienros merged 27 commits intoOrchardCMS:devfrom
Lombiq:WESD/dev
Aug 15, 2019
Merged

Live preview feature (Orchard.ContentPreview back-port; Lombiq Technologies: WESD-1)#8260
sebastienros merged 27 commits intoOrchardCMS:devfrom
Lombiq:WESD/dev

Conversation

@Piedone
Copy link
Copy Markdown
Member

@Piedone Piedone commented Aug 8, 2019

A back-port from the Orchard Core Orchard.ContentPreview module with the live preview feature. It's as close to the original module as possible. Done by @I3undy.

  • The module is intended work exactly as it works in Orchard Core.
  • Made the module compatible with the TinyMCE editor and the Layout Editor. Apart from these no enhancements or functionality changes are made to the module.

I3undy and others added 27 commits May 15, 2019 17:36
Back-porting the Orchard Core live preview feature (Lombiq Technologies: WESD-1)
@Piedone Piedone self-assigned this Aug 8, 2019
@sebastienros
Copy link
Copy Markdown
Member

Awesome!!!!
I remember a problem that was making it hard to do in O1, so please check that. When we create a new content item (.New) then a record is created in the database, maybe a new version actually, so we need to check every Render() call is not creating a new one. Or if it does then that it's not an issue.

@Piedone
Copy link
Copy Markdown
Member Author

Piedone commented Aug 8, 2019

Hmm, @I3undy please chime in but I don't think a persistent record is created on New() (record objects are, but they won't have an auto-increment Id assigned either). In any case we didn't notice any performance or other issues.

@Piedone
Copy link
Copy Markdown
Member Author

Piedone commented Aug 12, 2019

I just checked and it's not creating new versions during the preview, i.e. no new records e.g. in the Orchard_Framework_ContentItemVersionRecord table.

@sebastienros sebastienros merged commit 638a588 into OrchardCMS:dev Aug 15, 2019
@sebastienros
Copy link
Copy Markdown
Member

Will we get a demo on Tuesday?

@Piedone
Copy link
Copy Markdown
Member Author

Piedone commented Aug 15, 2019

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants