Skip to content

Improve Orchard.Layouts UX#8721

Merged
HermesSbicego-Laser merged 3 commits intoOrchardCMS:1.10.xfrom
LaserSrl:8720_LayoutPart_UX
Sep 1, 2023
Merged

Improve Orchard.Layouts UX#8721
HermesSbicego-Laser merged 3 commits intoOrchardCMS:1.10.xfrom
LaserSrl:8720_LayoutPart_UX

Conversation

@HermesSbicego-Laser
Copy link
Copy Markdown
Contributor

Improve UX of the LayoutPart Editor

@sebastienros
Copy link
Copy Markdown
Member

Can you share some screenshots before/after to understand the changes?

@HermesSbicego-Laser
Copy link
Copy Markdown
Contributor Author

HermesSbicego-Laser commented Sep 1, 2023

@sebastienros
Before
before - dev-layouts-New-Page (big toolbar)
before - dev-layouts-New-Page (big editor)

After
after - dev-layouts-New-Page (big toolbar)
after - dev-layouts-New-Page (big editor)

@HermesSbicego-Laser HermesSbicego-Laser merged commit ba0daf3 into OrchardCMS:1.10.x Sep 1, 2023
AndreaPiovanelli pushed a commit to LaserSrl/Orchard that referenced this pull request Sep 5, 2023
(cherry picked from commit ba0daf3)

# Conflicts:
#	src/Orchard.Web/Modules/Orchard.Layouts/Scripts/LayoutEditor.min.js
#	src/Orchard.Web/Modules/Orchard.Layouts/Styles/LayoutEditor.css
#	src/Orchard.Web/Modules/Orchard.Layouts/Styles/LayoutEditor.min.css
@HermesSbicego-Laser HermesSbicego-Laser deleted the 8720_LayoutPart_UX branch September 7, 2023 07:42
@BenedekFarkas
Copy link
Copy Markdown
Member

BenedekFarkas commented Mar 9, 2024

@HermesSbicego-Laser I'm working on #8773 now and there were some merge conflicts between 1.10.x and dev regarding some of the client-side assets. Recompilation works fine (which I find a positive surprise considering how outdated the compilation pipeline is) with Node v7 in the Task Runner Explorer.

I ran it first just on 1.10.x to validate the output and got the following results:

  • 233 js/css files were updated across various modules, but just their sourceMappingURLs.
  • In Orchard.Resources, a few files were updated functionality-wise, but everything still seems to be working fine there.
  • In Orchard.Layouts, which is affected by this PR, the LayoutEditor style and script are both updated functionality-wise.

Layouts still works great, but the layout editor toolbox became very restricted in terms of its height due to this specific line:
image

Can you please check what happens if you do a full recompilation of client-side assets with the rebuild task? I've committed the output from my local testing to the issue/8773-1.10.x branch (13bbb43) and then a rework of the sticky behavior (c420676).
image

@MatteoPiovanelli
Copy link
Copy Markdown
Contributor

@BenedekFarkas Could you please clarify what do you need us to check? What branch do you need us to try and rebuild the assets on?

@BenedekFarkas
Copy link
Copy Markdown
Member

I've moved on from this for a while, so I recompiled everything and resolved the issues already, but the issue was present on this PR's branch, as well as 1.10.x and dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants