-
Notifications
You must be signed in to change notification settings - Fork 4
add better example for heroku deploy script #177
base: master
Are you sure you want to change the base?
Conversation
99f4864
to
ab2971e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
what do you think about moving test/examples
=> examples
? the readme mentions the location of these, but it's nice when you can see it as a top level folder without having to look for them.
Sounds like a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again on my machine executables are in weird places. I have rustup and heroku installed via Nix; the $PATH
variable in the heroku example protocol does not include the directory with Nix-installed executables, so the tests are failing for me. I think the ideal solution would be to prepend to $PATH
instead of replacing its content, or to avoid changing $PATH
at all.
Also the new tests require the heroku app to be installed. Could we make a section in the documentation to list test prerequisites and list heroku there as a dependency?
++ to the https://doc.rust-lang.org/cargo/reference/manifest.html#examples |
89e2259
to
3062591
Compare
This adds a more comprehensive example. It's currently failing on CI because
heroku
is not installed there. So maybe this is blocked by #114?