Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

add better example for heroku deploy script #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soenkehahn
Copy link
Contributor

@soenkehahn soenkehahn commented Mar 25, 2019

This adds a more comprehensive example. It's currently failing on CI because heroku is not installed there. So maybe this is blocked by #114?

@soenkehahn soenkehahn force-pushed the sh/example branch 4 times, most recently from 99f4864 to ab2971e Compare March 25, 2019 20:24
Copy link
Contributor

@matthandlersux matthandlersux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

what do you think about moving test/examples => examples? the readme mentions the location of these, but it's nice when you can see it as a top level folder without having to look for them.

@soenkehahn
Copy link
Contributor Author

Sounds like a good idea.

Copy link
Contributor

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again on my machine executables are in weird places. I have rustup and heroku installed via Nix; the $PATH variable in the heroku example protocol does not include the directory with Nix-installed executables, so the tests are failing for me. I think the ideal solution would be to prepend to $PATH instead of replacing its content, or to avoid changing $PATH at all.

Also the new tests require the heroku app to be installed. Could we make a section in the documentation to list test prerequisites and list heroku there as a dependency?

@soenkehahn
Copy link
Contributor Author

@hallettj: I was thinking we could implement #114 before merging this. Then it would work on all machines. (It's also failing on CI right now, since heroku is not installed there.)

@data-pup
Copy link
Contributor

++ to the examples/ point made by @matthandlersux above. The examples/ is also special in that it is automatically compiled when you run your tests, so that they don't go out of date.

https://doc.rust-lang.org/cargo/reference/manifest.html#examples

@soenkehahn soenkehahn force-pushed the sh/example branch 3 times, most recently from 89e2259 to 3062591 Compare April 8, 2019 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants