New rule: No Typographic Quotes #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
May 16, 2025
OskarStark
reviewed
May 16, 2025
javiereguiluz
force-pushed
the
rule_quotes
branch
from
39e4919 to
8968683
Compare
|
I've done the required changes (and sorry for having deleted your commit with my force push 🙏) |
OskarStark
approved these changes
May 16, 2025
OskarStark
added a commit
that referenced
this pull request
May 16, 2025
* develop: New rule: No Typographic Quotes (#2011) Enhancement: Update dependencies in `composer.json` (#2010) Enhancement: Update dependencies in `composer.json` (#2009) Enhancement: Update dependencies in `composer.json` (#2008) Enhancement: Update dependencies in `composer.json` (#2007) composer(deps-dev): bump rector/rector from 2.0.15 to 2.0.16 (#2006) composer(deps-dev): bump phpunit/phpunit from 12.1.4 to 12.1.5 (#2005) composer(deps-dev): bump icanhazstring/composer-unused from 0.9.2 to 0.9.3 (#2004)
|
@javiereguiluz the 1.68.0 version is currently build. You can already prepare the PR on Symfony-docs 6.4 and enable the rule if you like. Thanks |
xabbuh
added a commit
to xabbuh/Twig
that referenced
this pull request
May 17, 2025
make DOCtor-RST 1.68 happy and account for OskarStark/doctor-rst#2011
fabpot
added a commit
to twigphp/Twig
that referenced
this pull request
May 18, 2025
This PR was merged into the 3.x branch. Discussion ---------- replace typographic quote with straigt single quote make DOCtor-RST 1.68 happy and account for OskarStark/doctor-rst#2011 Commits ------- 057ea92 replace typographic quote with straigt single quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good typography requires using curly quotes, but in tech docs is common to use straight quotes. We do that in Symfony Docs, so this rule ensures that the right quotes are always used.
I developed this rule to avoid mistakes like this that I recently did in Symfony Docs:
More info: