Repository navigation
fix(install): standardize OpenCode 1.18.32 and local-provider search - #6624
Merged
Merged
Conversation
Sensitive Files DetectedTrigger: Security-sensitive files detected: ods/installers/ Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
Sensitive Files DetectedTrigger: Security-sensitive files detected: ods/installers/ Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
Sensitive Files DetectedTrigger: Security-sensitive files detected: ods/installers/ Files flagged: Extra human review is recommended for this PR. Claude Code Review | Sensitive File Detection | ~$1.50 |
Merged
4 of 5 tasks
roshangupta00750
added a commit
to roshangupta00750/ODS
that referenced
this pull request
Sep 26, 2026
Seven suites fail on main and no workflow runs them: test-bootstrap-mode, test-cli-bootstrap-compose-wait, test-disk-space-preflight, test-ods-cli-bootstrap-env-refresh, test-preset-import-export, test-restore-safety-ux and test-tmpfile-cleanup. Their fixtures predate the current install tree, CLI and phase layout. test-tmpfile-cleanup also looked for the OpenCode download in phase 07, which Osmantic#6624 moved to installers/lib/opencode-runtime.sh; it now checks that the staging directory's EXIT trap sits in that subshell function. Main repaired test-linux-host-agent-stop, test-phase05-podman-shim and test-bootstrap-upgrade-close-inherited-fds, and test_system_uninstall.py passes, but none of them is run by CI either. Run all eleven in the Linux test job so they cannot go stale again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
roshangupta00750
added a commit
to roshangupta00750/ODS
that referenced
this pull request
Sep 29, 2026
Seven suites fail on main and no workflow runs them: test-bootstrap-mode, test-cli-bootstrap-compose-wait, test-disk-space-preflight, test-ods-cli-bootstrap-env-refresh, test-preset-import-export, test-restore-safety-ux and test-tmpfile-cleanup. Their fixtures predate the current install tree, CLI and phase layout. test-tmpfile-cleanup also looked for the OpenCode download in phase 07, which Osmantic#6624 moved to installers/lib/opencode-runtime.sh; it now checks that the staging directory's EXIT trap sits in that subshell function. Main repaired test-linux-host-agent-stop, test-phase05-podman-shim and test-bootstrap-upgrade-close-inherited-fds, and test_system_uninstall.py passes, but none of them is run by CI either. Run all eleven in the Linux test job so they cannot go stale again.
roshangupta00750
added a commit
to roshangupta00750/ODS
that referenced
this pull request
Sep 29, 2026
Seven suites fail on main and no workflow runs them: test-bootstrap-mode, test-cli-bootstrap-compose-wait, test-disk-space-preflight, test-ods-cli-bootstrap-env-refresh, test-preset-import-export, test-restore-safety-ux and test-tmpfile-cleanup. Their fixtures predate the current install tree, CLI and phase layout. test-tmpfile-cleanup also looked for the OpenCode download in phase 07, which Osmantic#6624 moved to installers/lib/opencode-runtime.sh; it now checks that the staging directory's EXIT trap sits in that subshell function. Main repaired test-linux-host-agent-stop, test-phase05-podman-shim and test-bootstrap-upgrade-close-inherited-fds, and test_system_uninstall.py passes, but none of them is run by CI either. Run all eleven in the Linux test job so they cannot go stale again.
roshangupta00750
added a commit
to roshangupta00750/ODS
that referenced
this pull request
Oct 2, 2026
Seven suites fail on main and no workflow runs them: test-bootstrap-mode, test-cli-bootstrap-compose-wait, test-disk-space-preflight, test-ods-cli-bootstrap-env-refresh, test-preset-import-export, test-restore-safety-ux and test-tmpfile-cleanup. Their fixtures predate the current install tree, CLI and phase layout. test-tmpfile-cleanup also looked for the OpenCode download in phase 07, which Osmantic#6624 moved to installers/lib/opencode-runtime.sh; it now checks that the staging directory's EXIT trap sits in that subshell function. Main repaired test-linux-host-agent-stop, test-phase05-podman-shim and test-bootstrap-upgrade-close-inherited-fds, and test_system_uninstall.py passes, but none of them is run by CI either. Run all eleven in the Linux test job so they cannot go stale again.
roshangupta00750
added a commit
to roshangupta00750/ODS
that referenced
this pull request
Oct 4, 2026
Osmantic#7282 repaired five of the suites this branch carried. What main still lacks: - test-tmpfile-cleanup.sh: the phase 05 check anchored on a message in the distro helpers, and the OpenCode check looked for a download that Osmantic#6624 moved to installers/lib/opencode-runtime.sh. Check every early return in _docker_install_from_script, and the EXIT trap that removes OpenCode's staging directory. - test-custom-menu-agent-flags.sh: phase 03 now asks about the developer CLIs (Osmantic#6930), resolves Pixel's search provider (Osmantic#6956) and checks the Portal chat default (Osmantic#6970). Stub the two lookups like the sibling phase 03 suites and count the new prompt. Phase 03 needs Bash 4, so re-exec under a modern Bash on macOS. - Both move from ci-not-run.txt to ci-suite.txt. - test-cli-bootstrap-compose-wait.sh: ods-cli needs Bash 4, so on macOS re-exec under a modern Bash like test-ods-cli-bootstrap-env-refresh.sh and run ods-cli with "$BASH". - test_system_uninstall.py: pin fixture unit files to 0644. Under the usual Ubuntu umask 002 they were 0664 and tripped the custody check.
Lightheartdevs
pushed a commit
that referenced
this pull request
Oct 4, 2026
#7282 repaired five of the suites this branch carried. What main still lacks: - test-tmpfile-cleanup.sh: the phase 05 check anchored on a message in the distro helpers, and the OpenCode check looked for a download that #6624 moved to installers/lib/opencode-runtime.sh. Check every early return in _docker_install_from_script, and the EXIT trap that removes OpenCode's staging directory. - test-custom-menu-agent-flags.sh: phase 03 now asks about the developer CLIs (#6930), resolves Pixel's search provider (#6956) and checks the Portal chat default (#6970). Stub the two lookups like the sibling phase 03 suites and count the new prompt. Phase 03 needs Bash 4, so re-exec under a modern Bash on macOS. - Both move from ci-not-run.txt to ci-suite.txt. - test-cli-bootstrap-compose-wait.sh: ods-cli needs Bash 4, so on macOS re-exec under a modern Bash like test-ods-cli-bootstrap-env-refresh.sh and run ods-cli with "$BASH". - test_system_uninstall.py: pin fixture unit files to 0644. Under the usual Ubuntu umask 002 they were 0664 and tripped the custody check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ODS previously kept any existing OpenCode binary on Linux/macOS and still pinned Windows to 1.2.18. Standardize new installs and reinstalls on stable 1.18.32 using one platform/architecture asset manifest with upstream SHA256 digests. Stage and verify replacements before installing; preserve existing binaries on failure and leave configuration/session directories intact. Windows reports a locked executable without killing its process.
Enable upstream Exa websearch in ODS launchers for local model providers. Upstream otherwise omits websearch from the selected local provider even when the global tool list includes it. Linux explicitly reloads, enables and restarts the managed service after a successful unit update, so an existing process cannot keep the old inode/environment. Explicit search-provider overrides are preserved. Existing permission checks remain in place; document the external search endpoint and require real selected-provider/search/source qualification.
Validation: focused Unix upgrade/rollback tests (9 cases in Git Bash and native Linux), Windows staging/replacement/locked-file tests (11 cases), release/launcher contracts (2 cases); existing Linux OpenCode path/opt-in, Windows config (26 checks) and timeout (16 checks) pass. Actual upstream Linux and Windows baseline archives were SHA256 verified and installed through the new helpers into owned temporary directories, both reporting 1.18.32, with no inference or changes to current installations. All 8 manifest digests match the canonical release API. Shell syntax and git diff checks pass.
The broad installer contract suite under Git Bash stopped at its existing symlinked-install ownership fixture before reaching OpenCode; native fleet installation and live search remain qualification work after merge. Historical 1.18.18 comparison receipts are retained, and no active comparator binary was replaced.