-
Notifications
You must be signed in to change notification settings - Fork 70
Adopt Pytest v9.0+, RuntimeWarning changes #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zeitsperre
wants to merge
8
commits into
main
Choose a base branch
from
pytest-v9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xarray merging operations will soon change to raise errors when data is overwritten Signed-off-by: Zeitsperre <[email protected]>
Signed-off-by: Zeitsperre <[email protected]>
Signed-off-by: Zeitsperre <[email protected]>
Signed-off-by: Trevor James Smith <[email protected]>
Signed-off-by: Trevor James Smith <[email protected]>
Signed-off-by: Trevor James Smith <[email protected]>
…ces, add silencing in idicator calls Signed-off-by: Zeitsperre <[email protected]>
Signed-off-by: Zeitsperre <[email protected]>
aulemahal
approved these changes
Dec 3, 2025
Collaborator
aulemahal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Approved for additional tests
dependencies
Pull requests that update a dependency file
indicators
Climate indices and indicators
standards / conventions
Suggestions on ways forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
RuntimeWarningmessages in order to provide more information for users ofindices, while silencing these messages forindicatorusers and the CLI.pytestto the latest conventions (version9.0+), enabling the newstrictmode.Does this PR introduce a breaking change?
For some developers, yes. There will likely be more noise emitted from workflows relying on
xclim.indices. These can be set to be ignored using context managers:or:
Other information:
The new
pytestnow offers astrictmode. This means that configurations formarkersandxfailmust be explicitly defined,parametrizationsmust always be uniquely-defined, and the configuration found inpyproject.tomlmust not contain any errors. For more information: https://docs.pytest.org/en/stable/reference/reference.html#confval-strict