Enable ArgumentParser to handle custom compilers
#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the original ArgumentParser class and subclasses with a single ArgumentParser that reads a configuration from the compiler TOML files. Signed-off-by: John Pennycook <[email protected]>
The new ArgumentParser interface is slightly different to the old one, and doesn't require a call to a recognize_compiler() function to construct. Signed-off-by: John Pennycook <[email protected]>
Replaces the original _importcfg with support for completely user-defined compilers (and argument parsers). Signed-off-by: John Pennycook <[email protected]>
Using the new user-defined compiler functionality for these tests allows us to test both the ability to define specific compiler behaviors, and our ability to detect incorrectly defined compilers. Signed-off-by: John Pennycook <[email protected]>
Every update to a PreprocessorConfiguration extends the same three lists, resulting in quite a lot of duplicated code in the original implementation. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
These tests only check whether we correctly detect cases where a user-defined parser references a custom action. They do not check the parser behavior, because this is covered by existing tests. Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
enhancement
10 tasks
|
The three uncovered lines are: except ValueError as e:
log.error(str(e))
returnI'd like to defer resolution of these until later. We should really have a utility function that checks these errors for TOML files, and I don't think it's worth introducing tests for each individual location in the code where we read a TOML file. |
Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
ClangArgumentParser,GnuArgumentParser, etc in favor of a single, configurable,ArgumentParser.ArgumentParserfrom thecompilers/*.tomlfiles and.cbi/configfile.