-
Notifications
You must be signed in to change notification settings - Fork 10
Prepare for 2.0.0 release #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All YAML functionality was deprecated in 1.2.0 and removed in 2.0.0. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
- Update version and DOI for 2.0.0 release. - Add Kelvin Lee as an author to reflect his contributions. Signed-off-by: John Pennycook <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the project for a major 2.0.0 release by updating dependency versions, the minimum required Python version, and version numbers across documentation and citation files.
- Removed unused dependencies and updated dependency versions in pyproject.toml
- Updated version numbers in docs/source/conf.py and README.md
- Revised citation metadata in CITATION.cff, including adding an author and updating the release date and DOI
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
pyproject.toml | Updated Python requirement and dependency versions |
docs/source/conf.py | Updated version and release strings to 2.0.0 |
README.md | Updated release version references and branch name in clone command |
CITATION.cff | Updated citation metadata with new version, release date, DOI, and added author |
Files not reviewed (1)
- docs/source/index.rst: Language not supported
Comments suppressed due to low confidence (3)
pyproject.toml:15
- Ensure that updating the minimum required Python version to 3.12 is fully compatible with all production components and documented in the release notes.
requires-python = ">=3.12"
pyproject.toml:27
- Review the major version bump for NumPy to ensure that this update does not introduce compatibility issues with other dependencies or production code.
"numpy==2.2.4"
CITATION.cff:18
- Confirm that the release date is accurate before merging; update it to reflect the actual release date if needed.
date-released: "2025-05-15"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment, otherwise LGTM
docs/source/index.rst
Outdated
release, run the following:: | ||
|
||
$ git clone --branch 1.2.0 https://github.com/intel/code-base-investigator.git | ||
$ git clone --branch 2.0.0 https://github.com/intel/code-base-investigator.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to roll this into a single step for users?
pip install git+https://github.com/intel/[email protected]
Unless you're developing CBI, I don't think this omits anything from the workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's much better. I've made this change in 827911f, for both the README and the docs. I left it in expanded form for the example showing how to install it in a virtual environment.
Signed-off-by: John Pennycook <[email protected]>
Related issues
N/A
Proposed changes
I set the date field to today, but I suspect the release will actually happen at some point in the next few days. I'll need to update that immediately prior to the merge, but everything else can be reviewed now.