Finalize coverage schema #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library only supports a single version of the coverage schema, and there is no reason for us to maintain this list of previous versions. Signed-off-by: John Pennycook <[email protected]>
We originally designed this to support a nested list, where inner lists represented regions (e.g., [[1, 4], [6, 8]]). We've never used this functionality, and it makes consuming coverage information more complicated than it needs to be. This is an example of premature optimization, so I'm reverting things to the simpler form. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Tracking only the used lines was sufficient to compute divergence, but is not sufficient to compute coverage; computing coverage requires information about the number of unused lines, in order to represent things as a percentage. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
The new results aren't accurate, in the sense that I didn't regenerate them to capture the true number of unused lines. This commit simply changes the format, replacing "lines" with "used_lines" and setting "unused_lines" to []. Signed-off-by: John Pennycook <[email protected]>
|
@swright87 - I don't think this should break anything that you've contributed here, but I wanted to make you aware of this change in case it impacts anything that you're doing with P3 Explorer. But if you and @laserkelvin agree on this direction, this should be the last breaking change to this format. |
|
I'm 99.9% sure it'll be fine with my contributions to P3, but it will likely impact some of the P3 Explorer stuff. I'll poke @Mxtt-smith to update |
laserkelvin
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
[[1, 5]]being equivalent to[1, 2, 3, 4, 5]) to simplify usage.linesintoused_linesandunused_lines, because this is required to compute coverage.