Adopt Vanadium SR1#332
Merged
Merged
Conversation
Contributor
Tobianas
commented
Apr 8, 2026
Tobianas
commented
- odlparent-14.3.1
- infrautils-7.1.12
- yangtools-14.0.23
- mdsal-15.0.4
- controller-12.0.5
- aaa-0.22.5
- netconf-10.0.3
- bgpcep-1.0.1
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several test files to include a no-op SSHNegotiatedAlgListener in createClient calls, updates YANG model import revisions, and bumps the maven-surefire-plugin version to 3.5.5. The review feedback recommends removing redundant explicit casts to SSHNegotiatedAlgListener in the test files to improve readability and ensuring consistent code formatting. Additionally, the YANG module should be updated with a new revision entry to reflect the changes in its imports.
Tobianas
force-pushed
the
23.x_vanadium_sr1
branch
3 times, most recently
from
43ce841 to
e6856dc
Compare
Adopt latest 23.x lighty.io version. JIRA: LIGHTY-428 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
opendaylight/netconf@45afbb4 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
opendaylight/netconf@c1b8141 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
opendaylight/netconf@db7b206 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
https://github.com/apache/maven-surefire/releases/tag/surefire-3.5.5 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 0a4a358)
ihrasko
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.