Skip to content

ci: windows support #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2022
Merged

ci: windows support #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
981c742
ci: windows support
carenas Apr 20, 2022
2b32d37
Merge branch 'master' into win32
PhilipHazel Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: Test (pcre2grep test script)
run: ./RunGrepTest

alpine:
name: alpine
runs-on: ubuntu-latest
Expand Down Expand Up @@ -56,3 +56,22 @@ jobs:

- name: Test (pcre2grep test script)
run: ./RunGrepTest

windows:
name: 32bit Windows
runs-on: windows-latest
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Configure
run: cmake -DPCRE2_SUPPORT_JIT=ON -DPCRE2_BUILD_PCRE2_16=ON -DPCRE2_BUILD_PCRE2_32=ON -B build -A Win32

- name: Build
run: cmake --build build

- name: Test
run: |
cd build\Debug
..\..\RunTest.bat

4 changes: 2 additions & 2 deletions RunTest.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ if "%all%" == "yes" (
set do7=yes
set do8=yes
set do9=yes
set do10=yes
set do10=no
set do11=yes
set do12=yes
set do12=no
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my worry. If something does not work, we might not be able to do anything with it, just disable tests. CI is usually good for actively developed targets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, we don't have yet functionality that allow us to debug remotely broken tests, which is why the only option now is to disable them.

but I happened to already build that for windows just because I was curious on why those 2 tests were failing and you can see both the code and a run with a downloadable set of files showing the output in:

https://github.com/carenas/pcre2/actions/runs/2199761640

there is also a tentative solution for Linux there, and of course fixes pending for the real underlying issue (which I am still puzzled about, because it will seem to be an extra empty line from pcre2test, and is consistently broken in that old OS github provides for its action VM)

set do13=yes
set do14=yes
set do15=yes
Expand Down