pcre2test: print max stack size in the right units #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a side note; do we really need to test with 64MB of stack nowadays? if I recall correctly the limit might had been increased because of some platforms that couldn't run without it (maybe Linux/m68k) but that was before 10.30 where the possibility of stack overflows was more likely.
AFAIK macOS uses 8M by default and was failing the -S call because the maximum allowed is a little less than 64M and therefore has been running fine with only that much (even before the latest improvements in 10.41)
if anything, and considering the trend to have multiple threads I would expect we should be instead looking at restricting the stack size (less than 1MB per thread stack size is IMHO common).