pcre2test: use microseconds instead of milliseconds for timing #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using -t or its variants the timing results with a modern CPU where not very significant even with 4 decimal digits. While at it, move the factor calculation that can be done with integer arithmetic and even optimized out for the more common case when CLOCKS_PER_SEC == 1000000 out of the denominator.
PhilipHazel
added a commit
that referenced
this pull request
Jan 19, 2023
PhilipHazel
added a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in Linux, macOS, Windows and even NetBSD armv7 (that uses CLOCKS_PER_SEC == 100) and new code is even smaller.
CLOCKS_PER_SEC == 1000000 is mandated by C89 / POSIX so I would expect no portability issues