pcre2grep: better compatibility for \d #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenas
changed the title
|
I agree with this in principle, but it probably needs leaving until #223 gets sorted out. |
Matching multi-byte digits was released with GNU grep 3.9 and considered a regression that required a couple more releases. While implementations differ on their interpretation of `\d` under Unicode, there is a recommendation[1] for a POSIX compatible mode that and a suggestion that it will be better (safer and faster) to only consider ASCII digits for that class (and [:digit]). Use the recently introduced PCRE2_EXTRA_ASCII_BSD if `--posix-digit` is used together with `-u` or `-U` for compatibility with GNU grep. [1] https://unicode.org/reports/tr18/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the discussion[1] from
gitby the GNUgrepdevelopers, and with the hope to prevent further divergence.The current implementation is mostly compatible with
git grep -Pandripgrep, and the behavior in UCP mode is mostly compatible with Perl, hence why adding it under a flag.[1] https://lore.kernel.org/git/[email protected]/