Add allocator check to pcre2_jit_compile #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Return value options for
|
|
I will update the documentation and add something to pcre2test. |
|
I have now done that in commit 4249b67. |
|
Thank you! |
gstrauss
added a commit
to gstrauss/lighttpd1.4
that referenced
this pull request
Aug 7, 2024
omit pcre2 JIT error trace if JIT not available due to system restrictions https://www.spinics.net/lists/git/msg452824.html Under Linux systems with SELinux's 'deny_execmem' or PaX's MPROTECT enabled, the allocation of PCRE2's JIT rwx memory may be prohibited, making pcre2_jit_compile() fail with PCRE2_ERROR_NOMEMORY (-48) PCRE2 10.45 adds PCRE2_JIT_TEST_ALLOC to test if JIT is available. PCRE2Project/pcre2#433 (With this patch, lighttpd omits trace for PCRE2 < 10.45 if JIT is available but the pattern is crazy and pcre2_jit_compile() fails. However, 'ok' to proceed since the pattern successfully compiled with pcre2_compile(), though might execute more slowly than with JIT.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.