Skip to content

pcre2grep: remove JFRIEDL_DEBUG obsoleted code #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Nov 14, 2021

No description provided.

Still uses the already obsoleted PCRE1 API

Signed-off-by: Carlo Marcelo Arenas Belón <[email protected]>
@PhilipHazel
Copy link
Collaborator

How do you know that this code is obsolete? It is several years since I corresponded with Jeffrey Friedl, but he may well still be running tests.

@carenas
Copy link
Contributor Author

carenas commented Nov 14, 2021

pcre_exec() doesn't exist in any 10.x version and therefore it doesn't build.

a "port" to 10.x might be possible, but it didn't seem to fit well with the surrounding code at first, and the functionality it has seems to be already available with other options (like timing report)

@PhilipHazel
Copy link
Collaborator

Ah, I had overlooked that. I guess JF hasn't used this facility since PCRE2 came along, and as that was nearly 7 years ago, I now agree that the code is indeed obsolete. Thanks for all the work you are doing, by the way. I will look at all the PRs in due course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants