pcre2grep: remove JFRIEDL_DEBUG obsoleted code #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still uses the already obsoleted PCRE1 API Signed-off-by: Carlo Marcelo Arenas Belón <[email protected]>
|
How do you know that this code is obsolete? It is several years since I corresponded with Jeffrey Friedl, but he may well still be running tests. |
|
pcre_exec() doesn't exist in any 10.x version and therefore it doesn't build. a "port" to 10.x might be possible, but it didn't seem to fit well with the surrounding code at first, and the functionality it has seems to be already available with other options (like timing report) |
|
Ah, I had overlooked that. I guess JF hasn't used this facility since PCRE2 came along, and as that was nearly 7 years ago, I now agree that the code is indeed obsolete. Thanks for all the work you are doing, by the way. I will look at all the PRs in due course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.