Re-apply "Use standard CMake constructs to export the targets. (#260)" #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts. (#260)" Additionally, I have attempted to clean up some CMake issues to make the package's build interface cleaner, in particular, avoiding polluting the parent directory's include path with our config.h file (if PCRE2 is being included as a subdirectory). This re-adds changes from Theodore's commit def175f, and partially reverts changes from Carlo's commit 92d56a1. --- Co-authored-by: Theodore Tsirpanis <[email protected]>
NWilson
force-pushed
the
user/niwilson/cmake-exports
branch
from
e0b3217 to
93215ed
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR re-applies a previous commit that updated how CMake exports targets and cleans up certain CMake issues related to the build interface.
- Reinstates standard target export handling.
- Cleans up the include path pollution by config.h for subdirectory builds with PCRE2.
- Enhances the CI workflows by adding tests for both the CMake install and build interfaces, and by explicitly setting the build type to Release in certain workflows.
Reviewed Changes
Copilot reviewed 2 out of 19 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/dev.yml | Adds a hack to rename target files to allow RunManifestTest to pass. |
| .github/workflows/build.yml | Adds new steps to test the CMake install and build interfaces and sets the build type to Release. |
Files not reviewed (17)
- CMakeLists.txt: Language not supported
- Makefile.am: Language not supported
- README: Language not supported
- cmake/pcre2-config-version.cmake.in: Language not supported
- cmake/pcre2-config.cmake.in: Language not supported
- doc/html/README.txt: Language not supported
- maint/.gitignore: Language not supported
- maint/cmake-tests/build-interface/CMakeLists.txt: Language not supported
- maint/cmake-tests/build-interface/main.c: Language not supported
- maint/cmake-tests/install-interface/CMakeLists.txt: Language not supported
- maint/cmake-tests/install-interface/main.c: Language not supported
- maint/manifest-cmakeinstall-freebsd: Language not supported
- maint/manifest-cmakeinstall-linux: Language not supported
- maint/manifest-cmakeinstall-macos: Language not supported
- maint/manifest-cmakeinstall-solaris: Language not supported
- maint/manifest-cmakeinstall-windows: Language not supported
- maint/manifest-tarball: Language not supported
NWilson
force-pushed
the
user/niwilson/cmake-exports
branch
4 times, most recently
from
b13776d to
f4eea83
Compare
NWilson
force-pushed
the
user/niwilson/cmake-exports
branch
from
f4eea83 to
5516409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I have attempted to clean up some CMake issues to make the package's build interface cleaner, in particular, avoiding polluting the parent directory's include path with our config.h file (if PCRE2 is being included as a subdirectory).
This re-adds changes from Theodore's commit
def175f, and partially reverts changes from Carlo's commit 92d56a1.
Fixes #115