Skip to content

Improve unicode property abbreviation support #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

zherczeg
Copy link
Collaborator

@zherczeg zherczeg commented Jan 6, 2022

No description provided.

@zherczeg
Copy link
Collaborator Author

zherczeg commented Jan 7, 2022

I have added a separate patch which fully auto-generates script names and their abbreviations. Of course the order of the script names is changed, so a lot of files changed as well. It also turned out that the abbreviation of Tangsa is tnsa, not tngs.

@PhilipHazel PhilipHazel merged commit f90542a into master Jan 7, 2022
@zherczeg zherczeg deleted the abbrevs branch January 7, 2022 10:09
@PhilipHazel
Copy link
Collaborator

I have merged these patches and updated the ucptest test data for the new script numbers. I have also put a temporary note in the README just in case someone wants to update the Unicode version. The lists of scripts in the user documentation are really getting too long to maintain by hand. I propose to add a new feature to pcre2test e.g. "pcre2test -list scripts" which will give a list of supported scripts. "-list properties" might also be useful. But I'll do the new property support first.

@zherczeg
Copy link
Collaborator Author

zherczeg commented Jan 8, 2022

When a new script is added, is it added to the end of Scripts.txt? If they randomly reorder them, we could force some ordering (e.g. alphabetic).

@PhilipHazel
Copy link
Collaborator

PhilipHazel commented Jan 8, 2022 via email

@zherczeg
Copy link
Collaborator Author

zherczeg commented Jan 8, 2022

It was just thinking loudly. It is easy to do, but will change the generated files, so the change would be big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants