Skip to content

PHP8 - Allow trailing comma in parameter list support #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2020
Merged

PHP8 - Allow trailing comma in parameter list support #5240

merged 1 commit into from
Nov 7, 2020

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum added topic/tests topic/PHP8.0 Related to features available in PHP 8.0+ labels Nov 6, 2020
@SpacePossum SpacePossum added this to the 2.15.10 milestone Nov 6, 2020
@SpacePossum SpacePossum mentioned this pull request Nov 6, 2020
Closed
62 tasks
@SpacePossum SpacePossum added the RTM Ready To Merge label Nov 7, 2020
@SpacePossum SpacePossum modified the milestones: 2.15.10, 2.17.0 Nov 7, 2020
@GrahamCampbell
Copy link
Contributor

Probably should add a multiline test case too (which will obviously work fine, but still good to have).

@SpacePossum SpacePossum merged commit ac82d55 into PHP-CS-Fixer:master Nov 7, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Nov 7, 2020
@SpacePossum SpacePossum deleted the master_PHP8_Allow_trailing_comma_in_parameter_list branch November 7, 2020 13:57
@SpacePossum
Copy link
Contributor Author

thanks, I'll put it on PHP8 check list 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic/PHP8.0 Related to features available in PHP 8.0+ topic/tests
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SpacePossum @GrahamCampbell