Skip to content

Composer: raise the minimum supported PHPCS version to 3.12.1 #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

Composer: raise the minimum supported PHPCS version to 3.12.1 #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Minimum Requirements
-------------------------------------------

* PHP 5.4 or higher.
* [PHP_CodeSniffer][phpcs-gh] version **3.8.0** or higher.
* [PHP_CodeSniffer][phpcs-gh] version **3.12.1** or higher.
* [PHPCSUtils][phpcsutils-gh] version **1.0.9** or higher.


Expand Down
10 changes: 0 additions & 10 deletions Universal/Sniffs/WhiteSpace/DisallowInlineTabsSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,6 @@ public function process(File $phpcsFile, $stackPtr)
}
}

/*
* For "yield from", we should only handle tabs _between_ the keywords (single token),
* not indentation for those situations where the keyword is split in multiple tokens.
*/
if ($tokens[$i]['code'] === \T_YIELD_FROM
&& \preg_match('`^yield.+from$`i', $tokens[$i]['content']) !== 1
) {
continue;
}

$fix = $phpcsFile->addFixableError(
'Spaces must be used for mid-line alignment; tabs are not allowed',
$i,
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"require" : {
"php" : ">=5.4",
"squizlabs/php_codesniffer" : "^3.8.0",
"squizlabs/php_codesniffer" : "^3.12.1",
"phpcsstandards/phpcsutils" : "^1.0.9"
},
"require-dev" : {
Expand Down