PassedParameters::hasParameters(): account for upstream tokenization change for parent
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
passedparameters/hasparameters-account-for-parent-tokenization-change
branch
11 times, most recently
from
51f6268 to
90617c4
Compare
…change for `parent` Upstream PR squizlabs/PHP_CodeSniffer 3546, which is included in PHPCS 3.7.0, changed the tokenization of the `parent` keyword in `new parent()` from `T_STRING` to `T_PARENT`. This has consequences for the `PassedParameters::hasParameters()` method and associated methods: * The `Collections::parameterPassingTokens()` method will now need to include the `T_PARENT` token. * The underlying `Collections::functionCallTokens()` method should as well. * The `PassedParameters::hasParameters()` method now needs to allow for the `T_PARENT` token potentially being used as part of a `new parent()` function call. This commit fixes all that up. Includes additional unit tests to safeguard it all (and some more).
jrfnl
force-pushed
the
passedparameters/hasparameters-account-for-parent-tokenization-change
branch
from
90617c4 to
21059b5
Compare
jrfnl
deleted the
passedparameters/hasparameters-account-for-parent-tokenization-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR squizlabs/PHP_CodeSniffer#3546, which is included in PHPCS 3.7.0, changed the tokenization of the
parentkeyword innew parent()fromT_STRINGtoT_PARENT.This has consequences for the
PassedParameters::hasParameters()method and associated methods:Collections::parameterPassingTokens()method will now need to include theT_PARENTtoken.Collections::functionCallTokens()method should as well.PassedParameters::hasParameters()method now needs to allow for theT_PARENTtoken potentially being used as part of anew parent()function call.This commit fixes all that up.
Includes additional unit tests to safeguard it all (and some more).