-
-
Notifications
You must be signed in to change notification settings - Fork 77
Refactor IsCamelCapsTest to use data providers and add more tests #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IsCamelCapsTest to use data providers and add more tests #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benno5020 Thank you so much for this PR! Great work!
The remarks I have are only nitpicks and I'd be happy to fix these up myself when merging if you prefer (just let me know).
Thank you for the kind words! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benno5020 Thank you for making those updates. All good from me 👍🏻
If you don't mind, I'll reorganize the commits to be atomic again, force push and then I'll merge once the build has passed.
When looking through the code again, I noticed that one test method's name and DocBlock were a little confusing so I changed it as well. See 755e941.
Agreed, that makes the description less confusing.
This commit moves all existing test cases to data providers and adds descriptive names to better convey what they intend to test. See PHPCSStandards#846
This commit aims to further document existing behaviour and tries to anticipate potential mistakes if the regular expressions are ever changed. See PHPCSStandards#846
755e941
to
ff8e0e0
Compare
@benno5020 We normally mention people by their name in the changelog. Under what name would you like me to attribute your contribution ? If you prefer not to share your name, I can use your handle instead. Just let me know your preference. |
Description
I've refactored the existing tests to use data providers and added more tests to document the existing behaviour. See #846
Suggested changelog entry
n/a
Related issues/external references
Fixes #846
Types of changes
PR checklist