Runner: distribute files round-robin by size in parallel mode - #1421
Open
janedbal wants to merge 3 commits into
Open
Runner: distribute files round-robin by size in parallel mode#1421janedbal wants to merge 3 commits into
janedbal wants to merge 3 commits into
Conversation
janedbal
marked this pull request as ready for review
April 28, 2026 14:03
6 tasks
simPod
approved these changes
Jun 20, 2026
jrfnl
reviewed
Jun 22, 2026
jrfnl
left a comment
Member
There was a problem hiding this comment.
@janedbal Thanks for this PR. Interesting proposal and nice performance gain.
Before I look at the code in detail, I'd like to ask you a couple of questions:
- Will this change the file order for the
Fullreport ?
I.e. if 20 files have issues, they are currently scanned by alphabetic file system order IIRC and the file reports will be ordered by this alphabetic file system order I believe. Will this order change with this PR ? - Can you think of a way that this change could be safeguarded via tests ?
This doesn't necessarily need to be unit tests, we also have a BashUnit test setup and aphpttest setup if that would help to allow for safeguarding the change via tests. - Can you think of a way that the performance improvement could be safeguarded via CI ?
- Can you guarantee that no AI was used to create this PR ?
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves same problem as #1419 but with much simplier approach.
Measurements:
3 mins 43 secs1 min 59 secs(~22 400 PHP files, 24 workers)
Suggested changelog entry
--parallelmode now better distributes work; gains up to 50% speedupTypes of changes
PR checklist