Generic/ScopeIndent: don't flag comments between stacked case statements - #1468
Open
lazerg wants to merge 1 commit into
Open
Generic/ScopeIndent: don't flag comments between stacked case statements#1468lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generic.WhiteSpace.ScopeIndentflagged the indentation of a comment placed between two stackedcase/defaultlabels that share a body. It expected the comment to line up with the case body instead of with the labels.The sniff already drops the indent it checks once it reaches a fall-through
case/defaultlabel, but a comment sitting right before such a label was still checked against the previous case's body indent. It now checks against the label indent, so a comment aligned with the labels no longer errors, and a comment at the body indent still passes too.Suggested changelog entry
Fixed:
Generic.WhiteSpace.ScopeIndent: a comment between stackedcase/defaultstatements is no longer flagged as incorrectly indented.Related issues/external references
Fixes #1460
Types of changes
PR checklist