Tests: make dataproviders static
#255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHPUnit 10, data providers are (again) expected to be `static` methods. While the test suite does not (yet) support PHPUnit 10, it's still not a bad idea to already start complying with this.
rodrigoprimo
added a commit
to rodrigoprimo/PHPCSDevTools
that referenced
this pull request
Apr 11, 2025
Per the PHPUnit manual: "A data provider method must be public and static" (https://docs.phpunit.de/en/12.0/writing-tests-for-phpunit.html). A similar change was done in the PHPCS repository: PHPCSStandards/PHP_CodeSniffer#255
rodrigoprimo
added a commit
to rodrigoprimo/PHPCSDevTools
that referenced
this pull request
Apr 11, 2025
Per the PHPUnit manual: "A data provider method must be public and static" (https://docs.phpunit.de/en/12.0/writing-tests-for-phpunit.html). A similar change was done in the PHPCS repository: PHPCSStandards/PHP_CodeSniffer#255 Tests will continue to work when running with PHPUnit < 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of PHPUnit 10, data providers are (again) expected to be
staticmethods. While the test suite does not (yet) support PHPUnit 10, it's still not a bad idea to already start complying with this.Suggested changelog entry
N/A
Related issues/external references
Loosely related to #25