Skip to content

Add links to all issues in the 3.6.0 section of the changelog #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rodrigoprimo
Copy link
Contributor

Description

This PR adds links to all issues in the 3.6.0 section of the changelog. Three typos were also fixed in a separate commit.

Related issues/external references

Part of #244

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo ! One thing to change before this can be merged.

As these are quite simple PRs, feel free to just use one commit for these type of changes.

CHANGELOG.md Outdated
@@ -610,7 +610,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
- Include patterns are now ignored when processing STDIN
- Previously, checks using include patterns were excluded when processing STDIN when no file path was provided via --stdin-path
- Now, all include and exclude rules are ignored when no file path is provided, allowing all checks to run
- If you want include and exclude rules enforced when checking STDIN, use --stdin-path to set the file path
- If you want to include and exclude rules enforced when checking STDIN, use --stdin-path to set the file path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This to changes the meaning of the sentence and is incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed this by amending the original commit.

@rodrigoprimo rodrigoprimo force-pushed the changelog-improvements-3-6-0 branch from 60e3525 to 8e3615d Compare January 19, 2024 11:50
@jrfnl jrfnl added this to the 3.9.0 milestone Jan 22, 2024
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo !

@jrfnl jrfnl merged commit b03d10f into PHPCSStandards:master Jan 22, 2024
jrfnl pushed a commit that referenced this pull request Jan 22, 2024
Includes fixing some typos in the 3.6.0 section of the changelog
@rodrigoprimo rodrigoprimo deleted the changelog-improvements-3-6-0 branch March 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants