-
-
Notifications
You must be signed in to change notification settings - Fork 73
Add links to all issues in the 3.6.0 section of the changelog #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to all issues in the 3.6.0 section of the changelog #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodrigoprimo ! One thing to change before this can be merged.
As these are quite simple PRs, feel free to just use one commit for these type of changes.
CHANGELOG.md
Outdated
@@ -610,7 +610,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo | |||
- Include patterns are now ignored when processing STDIN | |||
- Previously, checks using include patterns were excluded when processing STDIN when no file path was provided via --stdin-path | |||
- Now, all include and exclude rules are ignored when no file path is provided, allowing all checks to run | |||
- If you want include and exclude rules enforced when checking STDIN, use --stdin-path to set the file path | |||
- If you want to include and exclude rules enforced when checking STDIN, use --stdin-path to set the file path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This to
changes the meaning of the sentence and is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just fixed this by amending the original commit.
60e3525
to
8e3615d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodrigoprimo !
Includes fixing some typos in the 3.6.0 section of the changelog
Description
This PR adds links to all issues in the 3.6.0 section of the changelog. Three typos were also fixed in a separate commit.
Related issues/external references
Part of #244
Types of changes
PR checklist