Documentation: minor consistency fixes #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Verified that the contents of `<standard>` elements is consistently indented (with four spaces). * Verified that all `<code>` `title` attributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".
* Verified that the contents of `<standard>` elements is consistently indented (with four spaces). * Verified that all `<code>` `title` attributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".
The `invalid` block for the "tag order" was next to the "valid" PHP version code sample and visa versa.
* Verified that the contents of `<standard>` elements is consistently indented (with four spaces). * Verified that all `<code>` `title` attributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".
* Verified that the contents of `<standard>` elements is consistently indented (with four spaces). * Verified that all `<code>` `title` attributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".
Looks like this XML file was committed/accepted by accident / was an unfinished copy/paste error, as it has nothing to do with the `Squiz.Functions.FunctionDuplicateArgument` sniff. The sniff should be propely documented and the sniff has now been added to the task list in 148
* Verified that the contents of `<standard>` elements is consistently indented (with four spaces). * Verified that all `<code>` `title` attributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".
jrfnl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic/Documentation: minor consistency fixes
<standard>elements is consistently indented (with four spaces).<code>titleattributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".PEAR/Documentation: minor consistency fixes
<standard>elements is consistently indented (with four spaces).<code>titleattributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".Docs/PEAR//FileComment: fix up swapped valid/invalid blocks
The
invalidblock for the "tag order" was next to the "valid" PHP version code sample and visa versa.Docs/PEAR//FileComment: fix readability of the standard
Before
After
PSR1/2/12/Documentation: minor consistency fixes
<standard>elements is consistently indented (with four spaces).<code>titleattributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".Squiz/Documentation: minor consistency fixes
<standard>elements is consistently indented (with four spaces).<code>titleattributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".Squiz/FunctionDuplicateArgument: remove incorrect documentation
Looks like this XML file was committed/accepted by accident / was an unfinished copy/paste error, as it has nothing to do with the
Squiz.Functions.FunctionDuplicateArgumentsniff.The sniff should be properly documented and the sniff has now been added to the task list in #148
Zend/Documentation: minor consistency fixes
<standard>elements is consistently indented (with four spaces).<code>titleattributes use proper capitalization and punctuation and are prefixed with "Valid" or "Invalid".Suggested changelog entry
N/A
Related issues/external references
Loosely related to #148
Types of changes