GH Actions: auto-remove label tweaks #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 897 made a change to the "auto remove labels" workflow, but that change couldn't be tested until merged as it used the `pull_request_target` event, which always reads the workflows from the `master` branch and not from a PR branch. I've now tested the change and while the _new_ addition looks to be correct, one of the pre-existing jobs _also_ ran, while it shouldn't have run. This new commit attempts to fix that. Again, we can't test this until merged, but will test once it has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #897 made a change to the "auto remove labels" workflow, but that change couldn't be tested until merged as it used the
pull_request_targetevent, which always reads the workflows from themasterbranch and not from a PR branch.I've now tested the change and while the new addition looks to be correct, one of the pre-existing jobs also ran, while it shouldn't have run.
This new commit attempts to fix that.
Again, we can't test this until merged, but will test once it has been merged.
Suggested changelog entry
N/A