-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add JekyllPageGenerator #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<?php | ||
declare(strict_types=1); | ||
|
||
namespace App\Generator; | ||
|
||
use App\Value\Sniff; | ||
|
||
class JekyllPageGenerator extends MarkdownGenerator implements Generator | ||
{ | ||
public function createSniffDoc(Sniff $sniff): string | ||
{ | ||
$sniffDoc = $this->getFrontMatter($sniff) . "\n"; | ||
$sniffDoc .= parent::createSniffDoc($sniff); | ||
|
||
return $sniffDoc; | ||
} | ||
|
||
private function getFrontMatter(Sniff $sniff): string | ||
{ | ||
$sniffName = $sniff->getSniffName(); | ||
if ($sniffName === '') { | ||
return <<<'MD' | ||
--- | ||
--- | ||
|
||
MD; | ||
} | ||
|
||
return <<<MD | ||
--- | ||
title: {$sniffName} | ||
--- | ||
|
||
MD; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
declare(strict_types=1); | ||
|
||
namespace App\Tests\Generator; | ||
|
||
use App\Generator\JekyllPageGenerator; | ||
use App\Value\Sniff; | ||
use App\Value\UrlList; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
/** @covers \App\Generator\JekyllPage */ | ||
class JekyllPageTest extends TestCase | ||
{ | ||
private JekyllPageGenerator $generator; | ||
|
||
/** @test */ | ||
public function fromSniff_WithMinimalData_WriteMinimalDetails() | ||
{ | ||
$doc = new Sniff( | ||
'Standard.Category.My', | ||
'', | ||
[], | ||
new UrlList([]), | ||
'', | ||
[], | ||
[] | ||
); | ||
|
||
self::assertSame( | ||
<<<MD | ||
--- | ||
title: My | ||
--- | ||
|
||
# Standard.Category.My | ||
|
||
MD, | ||
$this->generator->createSniffDoc($doc) | ||
); | ||
} | ||
|
||
protected function setUp(): void | ||
{ | ||
$this->generator = new JekyllPageGenerator(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classes should be final and we should not extend implementations. It's okay to copy an existing to make the necessary changes. We can always extract truly reusable elements and inject them as dependencies instead. The test for the new class should encompass the common elements as well, otherwise we're not truly testing them, and any unintended regressions would go unnoticed. Not a deal breaker and I'm happy to address the issue in a subsequent commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's defer it and create a ticket to improve later.