Fix unit tests for all base conversion functions#12
Merged
MarkBaker merged 1 commit intoPHPOffice:developfrom Aug 13, 2016
PowerKiKi:unit-tests-base-conversion
Merged
Fix unit tests for all base conversion functions#12MarkBaker merged 1 commit intoPHPOffice:developfrom PowerKiKi:unit-tests-base-conversion
MarkBaker merged 1 commit intoPHPOffice:developfrom
PowerKiKi:unit-tests-base-conversion
Conversation
This include cases were artificial constraints were not checked (eg: between -512 and 511 for `DECBIN`) and some bugs were 32 bits platform were assumed. The following are covered: `BIN2DEC`, `BIN2HEX`, `BIN2OCT`, `DEC2BIN`, `DEC2HEX`, `DEC2OCT`, `HEX2BIN`, `HEX2DEC`, `HEX2OCT`, `OCT2BIN`, `OCT2DEC`, `OCT2HEX`
8 tasks
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
…sion Fix unit tests for all base conversion functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This include cases were artificial constraints were not checked
(eg: between -512 and 511 for
DECBIN) and some bugs were 32bits platform were assumed.
The following are covered:
BIN2DEC,BIN2HEX,BIN2OCT,DEC2BIN,DEC2HEX,DEC2OCT,HEX2BIN,HEX2DEC,HEX2OCT,OCT2BIN,OCT2DEC,OCT2HEX