Inherited Scrutinizer Recommendations - 1 of 3

src/PhpSpreadsheet/Reader/Csv.php

@@ -334,7 +334,7 @@ private function openFileOrMemory($pFilename): void
     public function loadIntoExisting($pFilename, Spreadsheet $spreadsheet)
     {
         $lineEnding = ini_get('auto_detect_line_endings');
-        ini_set('auto_detect_line_endings', true);
+        ini_set('auto_detect_line_endings', '1');
 
         // Open file
         $this->openFileOrMemory($pFilename);
@@ -528,7 +528,8 @@ public function canRead($pFilename)
         fclose($this->fileHandle);
 
         // Trust file extension if any
-        $extension = strtolower(pathinfo($pFilename, PATHINFO_EXTENSION));
+        $extension = pathinfo($pFilename, PATHINFO_EXTENSION);
+        $extension = is_array($extension) ? '' : strtolower($extension);
         if (in_array($extension, ['csv', 'tsv'])) {
             return true;
         }

src/PhpSpreadsheet/Reader/Xlsx.php

@@ -186,8 +186,7 @@ public function listWorksheetInfo($pFilename)
                 );
                 if ($xmlWorkbook->sheets) {
                     $dir = dirname($rel['Target']);
-                    /** @var SimpleXMLElement $eleSheet */
-                    foreach ($xmlWorkbook->sheets->sheet as $eleSheet) {
+                    foreach ($xmlWorkbook->sheets->sheet->children() as $eleSheet) {
                         $tmpInfo = [
                             'worksheetName' => (string) $eleSheet['name'],
                             'lastColumnLetter' => 'A',

src/PhpSpreadsheet/Reader/Xlsx/Hyperlinks.php

@@ -29,7 +29,9 @@ public function readHyperlinks(SimpleXMLElement $relsWorksheet): void
     public function setHyperlinks(SimpleXMLElement $worksheetXml): void
     {
         foreach ($worksheetXml->hyperlink as $hyperlink) {
-            $this->setHyperlink($hyperlink, $this->worksheet);
+            if ($hyperlink !== null) {
+                $this->setHyperlink($hyperlink, $this->worksheet);
+            }
         }
     }
 

src/PhpSpreadsheet/Spreadsheet.php

@@ -373,7 +373,9 @@ public function setUnparsedLoadedData(array $unparsedLoadedData): void
      */
     private function getExtensionOnly($path)
     {
-        return pathinfo($path, PATHINFO_EXTENSION);
+        $extension = pathinfo($path, PATHINFO_EXTENSION);
+
+        return is_array($extension) ? '' : $extension;
     }
 
     /**