Retitling Cloned Worksheets#4302
Merged
oleibman merged 4 commits intoPHPOffice:masterfrom Jan 8, 2025
Merged
Conversation
Fix PHPOffice#641 (marked stale in 2018, but now reopened). When a sheet's title is changed, PhpSpreadsheet updates references to the old sheet name found in formulas. Which is a good idea when the sheet is attached to the spreadsheet, but a bad idea when it isn't (often because it has been cloned without re-attaching to the spreadsheet). This PR continues to change formulas in the former case, but will no longer do so for the latter.
A little more useful than my first crack at this.
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Jan 7, 2025
Backport of PR PHPOffice#4302
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Jan 7, 2025
Backport of PR PHPOffice#4302.
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Jan 7, 2025
Backport of PR PHPOffice#4302.
11 tasks
oleibman
added a commit
that referenced
this pull request
Jan 8, 2025
11 tasks
oleibman
added a commit
that referenced
this pull request
Jan 8, 2025
11 tasks
oleibman
added a commit
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #641 (marked stale in 2018, but now reopened). When a sheet's title is changed, PhpSpreadsheet updates references to the old sheet name found in formulas. Which is a good idea when the sheet is attached to the spreadsheet, but a bad idea when it isn't (often because it has been cloned without re-attaching to the spreadsheet). This PR continues to change formulas in the former case, but will no longer do so for the latter.
This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.